-
Notifications
You must be signed in to change notification settings - Fork 178
hdl._mem: add MemoryData
class.
#1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1256 +/- ##
==========================================
- Coverage 89.80% 89.78% -0.03%
==========================================
Files 43 43
Lines 10008 10055 +47
Branches 2426 2439 +13
==========================================
+ Hits 8988 9028 +40
- Misses 823 831 +8
+ Partials 197 196 -1 ☔ View full report in Codecov by Sentry. |
whitequark
reviewed
Apr 2, 2024
whitequark
reviewed
Apr 2, 2024
whitequark
reviewed
Apr 2, 2024
This implements half of RFC 62. The `MemoryData._Row` class will be implemented later, as a follow-up.
whitequark
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements half of RFC 62. The
MemoryData._Row
class will be implemented later, as a follow-up.