Skip to content

vendor._altera: implement lib.io buffer primitives. #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

wanda-phi
Copy link
Member

@wanda-phi wanda-phi commented Apr 5, 2024

No description provided.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (6857daf) to head (4e2a653).
Report is 5 commits behind head on main.

❗ Current head 4e2a653 differs from pull request most recent head fed22cf. Consider uploading reports for the commit fed22cf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1284      +/-   ##
==========================================
- Coverage   90.56%   90.47%   -0.09%     
==========================================
  Files          44       44              
  Lines       10638    10644       +6     
  Branches     2595     2307     -288     
==========================================
- Hits         9634     9630       -4     
- Misses        818      823       +5     
- Partials      186      191       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpwrules
Copy link
Contributor

tpwrules commented Apr 5, 2024

Switched my design to this branch and it works well with Quartus 20.1.1.720. It only uses basic I/O though, not even bidirectional.

@wanda-phi wanda-phi force-pushed the lib-io-altera branch 3 times, most recently from 54046f1 to 4e2a653 Compare April 8, 2024 13:49
@wanda-phi wanda-phi marked this pull request as ready for review April 9, 2024 17:56
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is still not perfect but the Altera users will simply have to share our suffering.

@whitequark whitequark added this pull request to the merge queue Apr 9, 2024
Merged via the queue into amaranth-lang:main with commit 1b92901 Apr 9, 2024
19 checks passed
@wanda-phi wanda-phi deleted the lib-io-altera branch April 9, 2024 19:31
@whitequark whitequark added this to the 0.5 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants