Skip to content

hdl._ast: make Signal.like work properly with ShapeCastables. #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2024
Merged

hdl._ast: make Signal.like work properly with ShapeCastables. #1313

merged 1 commit into from
Apr 11, 2024

Conversation

wanda-phi
Copy link
Member

Fixes #1285.

@wanda-phi wanda-phi requested a review from whitequark as a code owner April 11, 2024 03:59
whitequark
whitequark approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whitequark whitequark added this pull request to the merge queue Apr 11, 2024
Merged via the queue into amaranth-lang:main with commit c59447c Apr 11, 2024
@wanda-phi wanda-phi deleted the signal-like branch April 11, 2024 05:21
@whitequark whitequark added this to the 0.5 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.

Signal.like is not fully functional with ShapeCastable-based signals
2 participants
@wanda-phi @whitequark