Skip to content

hdl: remove Value.implies. #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2024
Merged

hdl: remove Value.implies. #1392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1cbe0e
docs/changes: add missing `Value.implies` deprecation.
wanda-phi Jun 14, 2024
7052973
hdl: remove `Value.implies`.
wanda-phi Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions amaranth/hdl/_ast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,11 +994,6 @@ def xor(self):
"""
return Operator("r^", [self])

# TODO(amaranth-0.6): remove
@deprecated("`a.implies(b)` is deprecated, use `~a | b` instead")
def implies(self, conclusion):
return ~self | conclusion

def __check_shamt(self):
if self.shape().signed:
# Neither Python nor HDLs implement shifts by negative values; prohibit any shifts
Expand Down Expand Up @@ -2481,7 +2476,6 @@ def __repr__(self):
any = _proxy_value("any")
all = _proxy_value("all")
xor = _proxy_value("xor")
implies = _proxy_value("implies")
__lshift__ = _proxy_value("__lshift__")
__rlshift__ = _proxy_value("__rlshift__")
__rshift__ = _proxy_value("__rshift__")
Expand Down
7 changes: 5 additions & 2 deletions docs/changes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ Language changes

.. currentmodule:: amaranth.hdl

* Removed (deprecated in 0.4): :class:`Record`.
* Removed (deprecated in 0.5): public submodules of :mod:`amaranth.hdl`.
* Removed: (deprecated in 0.4) :class:`Record`.
* Removed: (deprecated in 0.5) public submodules of :mod:`amaranth.hdl`.
* Removed: (deprecated in 0.5) :meth:`Value.implies`.


Standard library changes
Expand Down Expand Up @@ -68,6 +69,7 @@ Apply the following changes to code written against Amaranth 0.4 to migrate it t
* Update uses of :meth:`Simulator.run_until <amaranth.sim.Simulator.run_until>` to remove the :py:`run_passive=True` argument. If the code uses :py:`run_passive=False`, ensure it still works with the new behavior.
* Update uses of :py:`amaranth.utils.log2_int(need_pow2=False)` to :func:`amaranth.utils.ceil_log2`.
* Update uses of :py:`amaranth.utils.log2_int(need_pow2=True)` to :func:`amaranth.utils.exact_log2`.
* Replace uses of :py:`a.implies(b)` with `~a | b`.


Implemented RFCs
Expand Down Expand Up @@ -138,6 +140,7 @@ Language changes
* Deprecated: :func:`amaranth.utils.log2_int`. (`RFC 17`_)
* Deprecated: :class:`amaranth.hdl.Memory`. (`RFC 45`_)
* Deprecated: upwards propagation of clock domains. (`RFC 59`_)
* Deprecated: :meth:`Value.implies`.
* Removed: (deprecated in 0.4) :meth:`Const.normalize`. (`RFC 5`_)
* Removed: (deprecated in 0.4) :class:`Repl`. (`RFC 10`_)
* Removed: (deprecated in 0.4) :class:`ast.Sample`, :class:`ast.Past`, :class:`ast.Stable`, :class:`ast.Rose`, :class:`ast.Fell`.
Expand Down