-
Notifications
You must be signed in to change notification settings - Fork 178
Fix tests on 3.12 #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests on 3.12 #799
Conversation
8be405c
to
adf8fbe
Compare
Codecov Report
@@ Coverage Diff @@
## main #799 +/- ##
==========================================
- Coverage 82.15% 82.04% -0.11%
==========================================
Files 51 50 -1
Lines 6908 6867 -41
Branches 1677 1670 -7
==========================================
- Hits 5675 5634 -41
+ Misses 1037 1036 -1
- Partials 196 197 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It looks like (according to @mwkmwkmwk) the following test failure is a Python regression and not an Amaranth issue:
I think I'll merge this PR since it's a clear improvement over status quo, and we can handle the coroutine issue later. |
This is causing issues on Python 3.12 and in any case should be based on the Python `ziglang` package instead of this cursed setuptools hack.
There is now an upstream deprecation warning for the same. We don't have to duplicate it.
(to be clear, I think it's a coverage.py issue on new Python version, not a Python regression) |
Ah sorry, I was distracted and missed that part! |
For reference, the remaining test failure is caused by python/cpython#105162 , which has just been fixed in git main; the fix will presumably be included in the next 3.12 beta. |
No description provided.