Admit non-signals in Simulator.write_vcd(traces=...)
#973
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than requiring each additional requested trace to be a signal, all of the signals in the provided value are added to the GTKW file and to the VCD file if they are not already there. This improves usability for `lib.data` as struct fields can now be added to traces.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
=======================================
Coverage 83.82% 83.83%
=======================================
Files 55 55
Lines 7959 7960 +1
Branches 1948 1949 +1
=======================================
+ Hits 6672 6673 +1
Misses 1076 1076
Partials 211 211 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than requiring each additional requested trace to be a signal, all of the signals in the provided value are added to the GTKW file and to the VCD file if they are not already there. This improves usability for
lib.dataas struct fields can now be added to traces.