-
Notifications
You must be signed in to change notification settings - Fork 178
[WIP/PoC] Add async testbench functions #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7da0601
to
5bef5c4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #990 +/- ##
==========================================
- Coverage 89.39% 88.84% -0.56%
==========================================
Files 43 43
Lines 9516 9611 +95
Branches 2283 2302 +19
==========================================
+ Hits 8507 8539 +32
- Misses 820 874 +54
- Partials 189 198 +9 ☔ View full report in Codecov by Sentry. |
5bef5c4
to
6faab6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I don't think we can really commit to this approach because it implements the new interface in terms of the old one and we want to deprecate and remove the old one. (We also want the new one to have less overhead, not more.)
I'm not intending to commit to this approach, but I think it'd be useful to prototype a simple working implementation first and write a suite of passing tests against it before starting on the «real» implementation. |
Yeah, no objection to that, of course. |
No description provided.