Skip to content

Add an RFC for Const from shape-castable. #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2024
Merged

Add an RFC for Const from shape-castable. #42

merged 1 commit into from
Feb 5, 2024

Conversation

zyp
Copy link
Contributor

@zyp zyp commented Jan 30, 2024 •
edited
Loading

@zyp zyp force-pushed the const-from-shape-castable branch from 09a2e90 to 528969f Compare January 30, 2024 22:02
@whitequark whitequark added meta:nominated Nominated for discussion on the next relevant meeting area:core RFC affecting APIs in amaranth-lang/amaranth labels Jan 30, 2024
@wanda-phi wanda-phi mentioned this pull request Feb 3, 2024
Closed
@whitequark
Copy link
Member

We have discussed this RFC on the 2024-02-05 weekly meeting. The disposition was to merge, without changes.

@galibert suggested that Shape should be ShapeCastable and Value should be ValueCastable to improve consistency within the language.

@whitequark whitequark removed the meta:nominated Nominated for discussion on the next relevant meeting label Feb 5, 2024
@whitequark whitequark mentioned this pull request Feb 5, 2024
Closed
@whitequark whitequark merged commit 3ba625b into amaranth-lang:main Feb 5, 2024
@whitequark
Copy link
Member

Thanks @zyp!

vk2seb added a commit to vk2seb/rfcs that referenced this pull request Nov 23, 2024
@vk2seb
RFC amaranth-lang#42: checkpoint at b345e8 from zyp:fixed-point-types…
5a99085 
… (unmodified)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:core RFC affecting APIs in amaranth-lang/amaranth
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zyp @whitequark