Skip to content
This repository was archived by the owner on Mar 24, 2020. It is now read-only.

Add non-'.graphql' filetype support for graphql operations codegen #46

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add non-'.graphql' filetype support for graphql operations codegen #46

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c94ca76
Recursively list nested stack resources
thisjeremiah Jan 16, 2019
6a0721e
Support writing non-'.graphql' filetype operations
thisjeremiah Jan 21, 2019
8163178
Merge
thisjeremiah Jan 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,15 @@ class ServerlessAmplifyPlugin {
const resource = resources.find(r => r.ResourceType === 'AWS::AppSync::GraphQLApi');
if (resource) {
const schemaFile = this.getTemporarySchemaFile(resource);
graphqlGenerator(schemaFile, fileDetails.filename, { language: 'graphql' });
const fileType = path.extname(fileDetails.filename).substr(1);
const language = {
ts: 'typescript',
js: 'javascript',
swift: 'swift',
scala: 'scala',
graphql: 'graphql',
}[fileType];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}[fileType];
}[fileType];
if(language == null) {
throw new Error(`File type '${fileType}' not supported for GraphQL operations`);
}

graphqlGenerator(schemaFile, fileDetails.filename, { language });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not provide any error handling when the language is not one of those listed. In that case, language will be explicitly undefined and that will cause horrible errors. Please add error handling appropriate to the situation.

} else {
throw new Error(`No GraphQL API found - cannot write ${fileDetails.filename} file`);
}
Expand Down