Skip to content

Commit f79a609

Browse files
msanallaSaeed Mahameed
authored and
Saeed Mahameed
committed
net/mlx5: Update log_max_qp value to FW max capability
log_max_qp in driver's default profile #2 was set to 18, but FW actually supports 17 at the most - a situation that led to the concerning print when the driver is loaded: "log_max_qp value in current profile is 18, changing to HCA capabaility limit (17)" The expected behavior from mlx5_profile #2 is to match the maximum FW capability in regards to log_max_qp. Thus, log_max_qp in profile #2 is initialized to a defined static value (0xff) - which basically means that when loading this profile, log_max_qp value will be what the currently installed FW supports at most. Signed-off-by: Maher Sanalla <[email protected]> Reviewed-by: Maor Gottlieb <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent 061f5b2 commit f79a609

File tree

1 file changed

+6
-2
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core

1 file changed

+6
-2
lines changed

drivers/net/ethernet/mellanox/mlx5/core/main.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,8 @@ enum {
9898
MLX5_ATOMIC_REQ_MODE_HOST_ENDIANNESS = 0x1,
9999
};
100100

101+
#define LOG_MAX_SUPPORTED_QPS 0xff
102+
101103
static struct mlx5_profile profile[] = {
102104
[0] = {
103105
.mask = 0,
@@ -109,7 +111,7 @@ static struct mlx5_profile profile[] = {
109111
[2] = {
110112
.mask = MLX5_PROF_MASK_QP_SIZE |
111113
MLX5_PROF_MASK_MR_CACHE,
112-
.log_max_qp = 18,
114+
.log_max_qp = LOG_MAX_SUPPORTED_QPS,
113115
.mr_cache[0] = {
114116
.size = 500,
115117
.limit = 250
@@ -523,7 +525,9 @@ static int handle_hca_cap(struct mlx5_core_dev *dev, void *set_ctx)
523525
to_fw_pkey_sz(dev, 128));
524526

525527
/* Check log_max_qp from HCA caps to set in current profile */
526-
if (MLX5_CAP_GEN_MAX(dev, log_max_qp) < prof->log_max_qp) {
528+
if (prof->log_max_qp == LOG_MAX_SUPPORTED_QPS) {
529+
prof->log_max_qp = MLX5_CAP_GEN_MAX(dev, log_max_qp);
530+
} else if (MLX5_CAP_GEN_MAX(dev, log_max_qp) < prof->log_max_qp) {
527531
mlx5_core_warn(dev, "log_max_qp value in current profile is %d, changing it to HCA capability limit (%d)\n",
528532
prof->log_max_qp,
529533
MLX5_CAP_GEN_MAX(dev, log_max_qp));

0 commit comments

Comments
 (0)