Fix incorrect constant #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Constants.COOKIE_TEST` does not exist, should be `Constants.COOKIE_TEST_PREFIX`.
kelvin-lu
approved these changes
Aug 26, 2020
|
Thanks so much for catching this! :) |
|
@kelvin-lu is this going to go out on npm now? our amplitude numbers have plummeted since we switched over to 7.1.0. I am assuming this would impact the numbers? |
|
right, this is a critical piece of how the sdk works. We'll be working to get these changes published today. |
|
@istrau2 the sdk has been republished, and we've updated our cdn's to reflect these changes - thanks again for the help! :) we really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constants.COOKIE_TESTdoes not exist, should beConstants.COOKIE_TEST_PREFIX.