Skip to content

fix(cookies): respect the options passed into cookies when testing to see if they're enabled #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2020
Merged

fix(cookies): respect the options passed into cookies when testing to see if they're enabled #294

merged 2 commits into from
Sep 17, 2020

Conversation

kelvin-lu
Copy link
Contributor

@kelvin-lu kelvin-lu commented Sep 11, 2020 •
edited
Loading

A potential fix for #271: When options (samesite, domain, etc.) are passed into the sdk, pass them into areCookiesEnabled on initializing MetadataStorage.

Fixes a test that was passing in the wrong option for metadata storage

@kelvin-lu kelvin-lu merged commit 61b6590 into master Sep 17, 2020
@jooohhn jooohhn deleted the kevlin-lu/respect-cookie-options branch September 18, 2020 21:34
github-actions bot pushed a commit that referenced this pull request Sep 22, 2020
@semantic-release-bot
chore(release): 7.2.0 [skip ci]
e1cc419 
# [7.2.0](v7.1.1...v7.2.0) (2020-09-21)

### Bug Fixes

* **cookies:** respect the options passed into cookies when testing to see if they're enabled ([#294](#294)) ([61b6590](61b6590))

### Features

* add logAttributionCapturedEvent option ([#295](#295)) ([309dac3](309dac3))
github-actions bot pushed a commit that referenced this pull request Sep 22, 2020
@semantic-release-bot
chore(release): 7.2.0 [skip ci]
319444c 
# [7.2.0](v7.1.1...v7.2.0) (2020-09-22)

### Bug Fixes

* **cookies:** respect the options passed into cookies when testing to see if they're enabled ([#294](#294)) ([61b6590](61b6590))

### Features

* add logAttributionCapturedEvent option ([#295](#295)) ([309dac3](309dac3))
github-actions bot pushed a commit that referenced this pull request Sep 22, 2020
@semantic-release-bot
chore(release): 7.2.0 [skip ci]
ef599fc 
# [7.2.0](v7.1.1...v7.2.0) (2020-09-22)

### Bug Fixes

* **cookies:** respect the options passed into cookies when testing to see if they're enabled ([#294](#294)) ([61b6590](61b6590))

### Features

* add logAttributionCapturedEvent option ([#295](#295)) ([309dac3](309dac3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@haoliu-amp haoliu-amp haoliu-amp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelvin-lu @haoliu-amp