Skip to content

fix: Fall back to the other ways, if the device Id is not available from get queries #302 #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2020
Merged

fix: Fall back to the other ways, if the device Id is not available from get queries #302 #303

merged 2 commits into from
Sep 25, 2020

Conversation

aoshika-lv
Copy link
Contributor

@aoshika-lv aoshika-lv commented Sep 24, 2020 •
edited by jooohhn
Loading

Make _getInitialDeviceId fall back to the other options/a base64Id, if the device Id is not available in the params via amp_device_id in case deviceIdFromUrlParam is true #302

Fixes #302

Please let me know, if there are any problems.

Checklist

  • Does your PR title have the correct title format
  • Does your PR have a breaking change? - No

kelvin-lu
kelvin-lu approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@kelvin-lu kelvin-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much for doing this for us - we can publish a minor patch for this soon :)

jooohhn
jooohhn suggested changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@jooohhn jooohhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small nit. Thank you for the PR!

@aoshika-lv
Copy link
Contributor Author

@kelvin-lu
Thank you so much!
I'm fixing it now, please wait for a while.

@aoshika-lv aoshika-lv requested a review from jooohhn September 25, 2020 03:03
@aoshika-lv
Copy link
Contributor Author

@jooohhn
I've fixed it. Please re-review at your convenience. Thanks!

@jooohhn jooohhn merged commit e0d39fd into amplitude:master Sep 25, 2020
github-actions bot pushed a commit that referenced this pull request Sep 25, 2020
@semantic-release-bot
chore(release): 7.2.2 [skip ci]
3da9633 
## [7.2.2](v7.2.1...v7.2.2) (2020-09-25)

### Bug Fixes

* Unavailable deviceId fallbacks ([#303](#303)) ([e0d39fd](e0d39fd)), closes [#302](#302)
@github-actions
Copy link

🎉 This PR is included in version 7.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jooohhn jooohhn Awaiting requested review from jooohhn

1 more reviewer

@kelvin-lu kelvin-lu kelvin-lu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

About the behavior that amp_device_id is not set when deviceIdFromUrlParam is true
3 participants
@aoshika-lv @jooohhn @kelvin-lu