Skip to content

fix: remove argument to function that takes no arguments #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2021
Merged

fix: remove argument to function that takes no arguments #370

merged 1 commit into from
Mar 12, 2021

Conversation

kelvin-lu
Copy link
Contributor

@kelvin-lu kelvin-lu commented Mar 12, 2021 •
edited
Loading

Summary

Not a bug, but would be confusing down the line. sendEventsIfReady takes no args.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@kelvin-lu kelvin-lu merged commit 777dead into main Mar 12, 2021
@kelvin-lu kelvin-lu deleted the 273/argument branch March 12, 2021 23:33
github-actions bot pushed a commit that referenced this pull request Mar 15, 2021
@amplitude-sdk-bot
chore(release): 8.0.0 [skip ci]
03a331d 
# [8.0.0](v7.4.4...v8.0.0) (2021-03-15)

### Bug Fixes

* call onError in init function ([#368](#368)) ([d2ae868](d2ae868))
* remove callback from argument to function that takes no arguments ([#370](#370)) ([777dead](777dead))
This was referenced Mar 16, 2021
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jooohhn jooohhn jooohhn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelvin-lu @jooohhn