Skip to content

build: auto generate snippet install instructions #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 23, 2021
Merged

build: auto generate snippet install instructions #447

merged 4 commits into from
Nov 23, 2021

Conversation

jooohhn
Copy link
Contributor

@jooohhn jooohhn commented Nov 16, 2021 •
edited
Loading

Summary

  • Adds script to create snippet install instructions and add it to our NPM publish
    • Can use the "embed" feature inside readme.io to grab latest contents (from jsDeliver) inside the developer docs so we don't have to manually update it anymore
  • Removes unused scripts

image

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: NO

@lgtm-com
Copy link

lgtm-com bot commented Nov 16, 2021

This pull request fixes 2 alerts when merging 8715ba0 into 355a05b - view on LGTM.com

fixed alerts:

  • 2 for Shell command built from environment values

yuhao900914
yuhao900914 reviewed Nov 17, 2021
View reviewed changes
scripts/create-snippet-instructions.js
`;
fs.writeFileSync(instructionsFileName, script);

console.log('Created amplitude-snippet-instructions.js');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the console?

@jooohhn jooohhn merged commit 74fed0a into main Nov 23, 2021
@jooohhn jooohhn deleted the build-snippet-dist branch November 23, 2021 20:47
@jooohhn jooohhn mentioned this pull request Nov 30, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@yuhao900914 yuhao900914 yuhao900914 left review comments

@qingzhuozhen qingzhuozhen qingzhuozhen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jooohhn @yuhao900914 @qingzhuozhen