Skip to content

Conversation

justin-fiedler
Copy link
Contributor

Summary

Catch top-level errors on Request.send in logEvents().

If send fails (XHR is unavialable) then events are removed from the queue after logging errors.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

Copy link
Contributor

@kevinpagtakhan kevinpagtakhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢

@justin-fiedler justin-fiedler merged commit 333f8a4 into main Jan 20, 2022
@justin-fiedler justin-fiedler deleted the AMP-47167-try-catch-send-events-request branch January 20, 2022 23:36
github-actions bot pushed a commit that referenced this pull request Jan 21, 2022
# [8.16.0](v8.15.1...v8.16.0) (2022-01-21)

### Bug Fixes

* catch errors with Request.send ([#490](#490)) ([333f8a4](333f8a4))

### Features

* accept custom session id paramter in config ([#485](#485)) ([b64b8b0](b64b8b0))
* allow cors header to be excluded from request headers ([#489](#489)) ([0119ac7](0119ac7))
@github-actions
Copy link

🎉 This PR is included in version 8.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sendAmplitudeEvent Success and Failure callbacks are not called if request blocked at browser level (Brave Browser)

2 participants