Limit property keys #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trashstack
suggested changes
Oct 4, 2016
| return {}; | ||
| } | ||
|
|
||
| if (Object.keys(properties).length > constants.MAX_PROPERTY_KEYS) { |
There was a problem hiding this comment.
Object.keys gives an objects own enumerable properties whereas for .. in loops over inherited enumerable properties as well. So there's an edge case where identify.set might still get called more than 1000 times.
trashstack
approved these changes
Oct 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to limit event properties / user properties in a single SDK call to 1000. The only time 1000 has ever been exceeded is when the customer accidentally sets too many, for example in like a loop.