fix: attach timestamp to impression events #223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This update will attach timestamps to
$impression
events when they are incurred.This is necessary for consent-aware exposure tracking, which keeps
$impression
events in memory when consent status isPENDING
. When status is updated toGRANTED
, the timestamp is required to properly track when the event was incurred, and not when the event was processed by the analytics SDK.Relevant
analytics-browser
PR.Checklist