Skip to content
This repository was archived by the owner on Jun 28, 2025. It is now read-only.

add dep tslib #84

Merged
merged 3 commits into from
Sep 28, 2020
Merged

add dep tslib #84

merged 3 commits into from
Sep 28, 2020

Conversation

milahu
Copy link
Contributor

@milahu milahu commented Sep 23, 2020

tslib is required for 'npm run build'

> rollup -c rollup.config.js

src/remapping.ts → dist...
[!] (plugin typescript) Error: @rollup/plugin-typescript TS2354: This syntax requires an imported helper but module 'tslib' cannot be found.

currently, tslib is only in package-lock.json but not in package.json

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@google-cla
Copy link

google-cla bot commented Sep 23, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@milahu
Copy link
Contributor Author

milahu commented Sep 23, 2020

@googlebot I signed it!
what would this world be without lawyers? of course, nothing!

Copy link
Collaborator

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out!

@jridgewell jridgewell merged commit 91c3160 into ampproject:master Sep 28, 2020
jridgewell added a commit to jridgewell/sourcemaps that referenced this pull request Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants