Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Jun 26, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

We should reset the SSH passphrase when the user imports a new private key.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

📸 Screenshots / GIFs

@fmeum fmeum merged commit 6b5984d into android-password-store:develop Jun 26, 2020
@msfjarvis msfjarvis mentioned this pull request Jun 26, 2020
6 tasks
msfjarvis added a commit that referenced this pull request Jun 27, 2020
* develop: (24 commits)
  UI fixups (#892)
  Update Public Suffix List data (#888)
  Use remembered credential even if it is empty (#880)
  Reset SSH passphrase after SSH key import (#885)
  Prevent cached passwords from being wiped (#884)
  build: uprev all dependencies (#882)
  github: update actions for updated branching logic
  Use a custom sshj config (#878)
  Remove API 30 from pull request test matrix (#879)
  Add Google Play/F-Droid badges to the README (#877)
  Retire Android Arsenal badge (#876)
  Add paragraphs to F-Droid summary (#874)
  Replace YAML with HTML in F-Droid fastlane summary (#873)
  Add relnotes for #871 (#872)
  Add org.gnu.icecat as a trusted multi-origin browser (#871)
  README: re-add F-Droid (#870)
  build: prepare next development version
  build: bump version to 1.9.0
  Prepare release 1.9.0
  PasswordCreationActivity: properly guard rename code
  ...

Signed-off-by: Harsh Shandilya <[email protected]>
msfjarvis added a commit that referenced this pull request Jul 1, 2020
* develop:
  Scroll to files and enter folders when created (#909)
  Run a treewide reformat (#908)
  Improve how secrets and stored and used (#907)
  Improve and refactor Autofill heuristics (#905)
  Use PreferenceKeys file to manage SharedPreferences keys. (#891)
  Bump version
  Prepare release 1.9.2
  update changelog
  Workaround to prevent crash on first run (#898)
  build: bump version
  Prepare release 1.9.1
  Backport Actions fixes (#894)
  Remove API 30 from pull request test matrix (#879)
  CHANGELOG: reword to better clarify fixes
  Prevent cached passwords from being wiped (#884)
  Use remembered credential even if it is empty (#880)
  Reset SSH passphrase after SSH key import (#885)
  Add relnotes for #871 (#872)
  Add org.gnu.icecat as a trusted multi-origin browser (#871)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants