Update lodash.bind to version 4.0.0 🚀 #11
Conversation
|
This is being used only in one place, which is in the browser handler of At a glance, this build appears to be breaking because of a timing issue where a dependency of lodash-bind wasn't on npm yet. |
|
Kicked off the builds again, will wait to merge this to give those IE6 fans time to speak up. |
|
If you're going to lose IE6-8 support anyway, you may as well just drop the dep and use ES5 bind |
|
You're right, and when I went to look at the rest of lib/connection I remembered why it's like this. The entire reason we're using this (notice how we use es5 bind in non-browser) is because [email protected] (our test suite) does not support this ariya/phantomjs#10522 |
|
Additionally, because of build problems on os x and linux, it won't be available on npm untill 2.1 Medium/phantomjs#288 |
|
A different approach might be to just pull in a polyfill - should solve the problem, and the polyfill is unlikely to change or be deprecated for the foreseeable future. |
|
Yeah I'm pretty torn on this. After my work on amp I'm pretty gun shy about re-implementing things like this. I think ultimately the problem of removing this is separate from the smaller one of "should we update" I think we can just update, since there's no real expectation of support below IE9 here anyways, and wait for [email protected] (Or some other solution we haven't thought of) before removing it altogether. |
|
Ok gonna try this https://twitter.com/philip_roberts/status/687407032715067393 |
Instead of using lodash.bind in the main code, just override function.prototype.bind during the browser test code
Switch to eslint-config-andyet/es5
|
So, since we're only concerned about the fact that phantomjs doesn't have the polyfill, not whether or not the user browser does in production, we moved the shim into the test script. I think this works. Really not concerned about legacy browser support. |
It was too easy to confuse with the exported browser sub library
|
I renamed the browser test file so as to not be confused with the exported |
|
Oh right, I was indeed confused! |
Remove apparently stale mention of assert and explain file's purpose a litle better
|
thanks for being a sounding board for this @pdf I'm pretty happy with where it ended up. I'll merge this tomorrow morning (PST) |
Update lodash.bind to version 4.0.0 🚀
|
Websockets weren't available pre IE10 so this isn't a breaking change, patch release |
|
published as |
Hello 👋
🚀🚀🚀
lodash.bind just published its new version 4.0.0, which is not covered by your current version range.
If this pull request passes your tests you can publish your software with the latest version of lodash.bind – otherwise use this branch to work on adaptions and fixes.
Happy fixing and merging 🌴
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? Upgrade to the supporter plan! You'll also get your pull requests faster ⚡It keeps your software, up to date, all the time.