This repository was archived by the owner on Jul 21, 2020. It is now read-only.
Native TypeScript support #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andywer
force-pushed
the
feature/typescript-support
branch
from
f52d4a1 to
03fdced
Compare
andywer
force-pushed
the
feature/typescript-support
branch
from
03fdced to
5b81435
Compare
Merged
andywer
force-pushed
the
feature/typescript-support
branch
from
5b81435 to
bfa518b
Compare
|
I'm actually excited to get TS support within AVA although it seems like the code changes weren't significant to get it running. I'm wondering if these code changes could have been proposed in AVA directly, or if there was some compromise AVA wasn't ready to make now? |
|
@Magellol I am not sure what the motivations or obstacles for the AVA team are right now, but yeah, the changes are rather small. It is not trivial to re-integrate the changes back into the main repo without breaking JS support and without refactoring AVA's code quite a bit, though. I think TypeScript is just not a priority to them. Feel free to ask them; I just quickly created a solution that satisfies my immediate needs here :) |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR encapsulates the changes necessary to make AVA work with TypeScript source and test files.
Tests will be fixed by #2.