Skip to content

Mark occurrences is missing. #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
angelozerr opened this issue Mar 12, 2016 · 6 comments
Closed

Mark occurrences is missing. #17

angelozerr opened this issue Mar 12, 2016 · 6 comments

Comments

@angelozerr
Copy link
Owner

Mark ocurrences is missing.

@angelozerr
Copy link
Owner Author

@micaelgallego could you give me a sample which doesn't work? In my case it works for variable.

I know that tsserver provides a service to so that. We have 2 choices:

@micaelgallego
Copy link

Effectively "Mark occurrences" works for variables. But only for variables ;)

Screenshot working for variables:
image

Screenshot not working for methods:

image

Screenshot not working for attributes:

image

@micaelgallego
Copy link

Is there any service in tsserver to implement this behavior?

@angelozerr
Copy link
Owner Author

Yes I think, but I must study it.

@angelozerr angelozerr changed the title Mark ocurrences is missing. Mark occurrences is missing. Apr 14, 2016
@angelozerr
Copy link
Owner Author

@micaelgallego I have implemented "Mark occurrences" by consumming tsserver with "occurrences" command. It works well except that it freezes Eclipse when editor got the focus and tsserver is not started. I must improve really that by consumming tsserver with asynch mean (hope it will work).

angelozerr pushed a commit that referenced this issue Apr 16, 2016
@angelozerr
Copy link
Owner Author

angelozerr commented Apr 18, 2016

Mark occurrences is now done with async to avoid freezing Eclipse

Mark Occurrences

See https://github.com/angelozerr/typescript.java/wiki/Editor-Features#mark-occurrences for more information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants