Skip to content

Refactor rename support #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
micaelgallego opened this issue Mar 12, 2016 · 7 comments
Closed

Refactor rename support #28

micaelgallego opened this issue Mar 12, 2016 · 7 comments
Milestone

Comments

@micaelgallego
Copy link

When I use Ctrl+R it appears a dialog error with message "Operation unavailable in the current selection"

@micaelgallego
Copy link
Author

With the new editor nothing happens when I type Alt+Shift+R. I wish that a rename dialog appear.

@angelozerr
Copy link
Owner

Yes I must implement it by using tsserevr rename command. Never implemented refactoring, so I don't know if it's easy.

@angelozerr angelozerr added this to the 1.1.0 milestone Sep 15, 2016
@angelozerr angelozerr removed this from the 1.1.0 milestone Oct 19, 2016
angelozerr added a commit that referenced this issue Apr 21, 2017
@angelozerr angelozerr changed the title Refactor rename is not working Refactor rename support Apr 21, 2017
@angelozerr angelozerr added this to the 1.3.0 milestone Apr 21, 2017
angelozerr added a commit that referenced this issue Apr 21, 2017
angelozerr added a commit that referenced this issue Apr 21, 2017
angelozerr added a commit that referenced this issue Apr 23, 2017
@danielvanmil
Copy link

+1 : any updates on this issue or expected release 1.3.0? This is really a feature I miss in between all the excellent work!

@angelozerr
Copy link
Owner

If you install 1.3.0-SNAPSHOT you should having refactoring. Please test it and give me feedback.

@danielvanmil
Copy link

testing, looks good

@danielvanmil
Copy link

With the compileOnSave option enabled: refactoring goes well in the code except that not all the changed files get recompiled so Eclipse shows errors in the problem views that are not valid. Saving the files with the errors without any changes updates the problem view again so it views the correct data (no problems).

This should be easy to fix by also compiling all changed files during the rename/refactor action?

@angelozerr
Copy link
Owner

I close this issue, @danielvanmil please creat ea new issue with your problem with more info (I cannot reproduce it). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants