Skip to content

Reactive Forms broken in Version 10 of angular-redux/forms #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
Ebg-Bibi opened this issue Jun 25, 2019 · 1 comment
Closed
2 tasks

Reactive Forms broken in Version 10 of angular-redux/forms #91

Ebg-Bibi opened this issue Jun 25, 2019 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists pkg: form Related to the form package

Comments

@Ebg-Bibi
Copy link

This is a...

  • feature request
  • [x ] bug report
  • usage question

The "ReactiveConnectDirective" extends ConnectBase but does not set the protected field "form" anymore.

In Version 9 the Input property formGroup in "ReactiveConnect" is declared as:

@input('formGroup') form: any;

In Version 10 it is declared as:

@input() formGroup: any;

So ConnectBase.form is no longer set to the formGroup attributes value.

This breaks ConnectBase.resetState which is called from ConnectBase.ngAfterContentInit:

const formElement =
this.form.control === undefined ? this.form : this.form.control;

this.form is undefined and accessing control causes an error.
@smithad15 smithad15 added bug Something isn't working duplicate This issue or pull request already exists pkg: form Related to the form package labels Jul 7, 2019
@smithad15
Copy link
Member

Duplicate of #85

@smithad15 smithad15 marked this as a duplicate of #85 Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists pkg: form Related to the form package
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smithad15 @Ebg-Bibi