Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Progress doesn't work with BS3 #1241

Closed
pkozlowski-opensource opened this issue Nov 9, 2013 · 7 comments
Closed

Progress doesn't work with BS3 #1241

pkozlowski-opensource opened this issue Nov 9, 2013 · 7 comments

Comments

@pkozlowski-opensource
Copy link
Member

No description provided.

@pkozlowski-opensource
Copy link
Member Author

This got fixed in the BS3 branch via a3d53d8

@buberdds
Copy link

@pkozlowski-opensource my commit was not good enough, that's why it was closed ;] Please look at the demo page, first examples are not working correctly. danger and warning progress bars have wrong colors. The markup in the twitter bootstrap 3 has changed much more. I'll try to fix this today or tommorow, cya

@pkozlowski-opensource
Copy link
Member Author

@buberdds oh, sorry, it is a good lesson for me not to merge things when it is late and I'm tired. Some of the pull request where accidentally closed recently so I've figured this one is part of those. Going to re-open this issue, any help on definite fix would be awesome.

@bekos
Copy link
Contributor

bekos commented Nov 30, 2013

@pkozlowski-opensource Can you revert a3d53d8? Also, will you help rebase bs3?

@leon
Copy link

leon commented Dec 1, 2013

I've fixed the progressbar by allowing to set the type on the progress and passing it down to the makeBar function.
This shouldn't break anything since it's a additional attribute.
We could also add a watch to it so that you can have angular automatically update the type.

What do you think?

@pkozlowski-opensource
Copy link
Member Author

@bekos I believe this one is fixed now, right? Closing, please re-open if there are any remaining items to tackle.

@bekos
Copy link
Contributor

bekos commented Dec 27, 2013

@pkozlowski-opensource Sure :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants