-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Progress doesn't work with BS3 #1241
Comments
This got fixed in the BS3 branch via a3d53d8 |
@pkozlowski-opensource my commit was not good enough, that's why it was closed ;] Please look at the demo page, first examples are not working correctly. danger and warning progress bars have wrong colors. The markup in the twitter bootstrap 3 has changed much more. I'll try to fix this today or tommorow, cya |
@buberdds oh, sorry, it is a good lesson for me not to merge things when it is late and I'm tired. Some of the pull request where accidentally closed recently so I've figured this one is part of those. Going to re-open this issue, any help on definite fix would be awesome. |
@pkozlowski-opensource Can you revert a3d53d8? Also, will you help rebase bs3? |
I've fixed the progressbar by allowing to set the type on the progress and passing it down to the makeBar function. What do you think? |
@bekos I believe this one is fixed now, right? Closing, please re-open if there are any remaining items to tackle. |
@pkozlowski-opensource Sure :-) |
No description provided.
The text was updated successfully, but these errors were encountered: