-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Tooltip append-to-body? #2445
Comments
@sgarbesi how would you like to specify a parent? I can think of 2 options:
Can you think of something else that would be generic and easy to implement? |
@pkozlowski-opensource passing a reference to the instance of the element should suffice?
You could probably even have a special case:
Redirect to document.getElementsByTagName('body')[0] ? Sorry for not being clear enough. I wasn't looking for a CSS selector, but rather a CSS class to apply to the tooltips in question.
When the tooltip is spawned it now has a class of test123. |
Yes, this could be an option - but this kind of promotes non-AngularJS API so I'm not sure I want to go down this path. There is some discussion in the AngularJS itself about allowing all selectors for angular.element, so it might get easier with time. Alternatively, we could use http://caniuse.com/queryselector as it seems to be supported in all browsers we care about supporting. Yeh, this should be doable. |
@pkozlowski-opensource Sounds okay to me. You plan on coding this or should I give it a shot and make a pull request? |
Closing this due to inactivity. Please feel free to reopen if this is still an issue and you would like to submit a PR. |
Instead of append-to-body why not have it be append-to-parent that way we can choose a specific parent we want to append the tooltips to?
I'm having an issue where I need the tooltip to live within a specific container so I can give it a unique style that differs from the rest of the website. The problem is the tooltip mucks with the positioning of other elements being in the current container.
...or having a tooltip-class would be even better! I see the benefits in having both. I don't see the benefits of restricting the options to simply the body and current container. Would this not be an easy implementation?
The text was updated successfully, but these errors were encountered: