Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

feat(tooltip): html content from an element #545

Closed
tomsdev opened this issue Jun 21, 2013 · 6 comments
Closed

feat(tooltip): html content from an element #545

tomsdev opened this issue Jun 21, 2013 · 6 comments

Comments

@tomsdev
Copy link

tomsdev commented Jun 21, 2013

See this thread: https://groups.google.com/forum/#!category-topic/angular-ui/bootstrap/3m-fqNQ6plM

@pkozlowski-opensource
Copy link
Member

@tomsdev This is a very much requested feature for which we've got an issue opened already:
#220

There is also an associated pull request (#369) but it still needs more work.

The approach we've been taking so far was slightly different as the idea was not to relay on the DOM elements and their ids but rather to provide the templateUrl attribute.

At the end of the day both approaches are more or less equivalent as you can embed partials with the <script> directive if you really like to have them as part of the main template. But using templateUrl gives you additional flexibility to load popover content from a separate file if needed (and this way avoid putting in the DOM tree things that might be never shown).

In short: would be awesome to have a complete pull request for this. Would do you think of using templateUrl instead of relaying on ids of elements embedded in the main template? @joshdmiller any input?

@tomsdev
Copy link
Author

tomsdev commented Jun 21, 2013

@joshdmiller approach seems great. However, it seems that bindings with ng-model don't work.

What work is needed to have a complete pull request?

@pkozlowski-opensource
Copy link
Member

@tomsdev Great. The PR #369 has a list of missing things. As for a complete PR we need tests and docs / demo side update.

@ajoslin
Copy link
Contributor

ajoslin commented Jul 27, 2013

#641 has popover-html-unsafe - if/when that is merged tooltip will come I think

@tomsdev
Copy link
Author

tomsdev commented Jul 27, 2013

No, popover-html-unsafe doesn't support angularjs bindings and directives in the content.

@chrisirhc
Copy link
Contributor

Closing this as duplicate of #220.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants