Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

feat(popover): add popover-html-unsafe directive #641

Closed
wants to merge 2 commits into from

Conversation

dcg
Copy link

@dcg dcg commented Jul 9, 2013

This Feature enables the User to add HTML-Formatted Content to a popover

See: Issue #520

This Feature enables the User to add HTML-Formatted Content to a popover

See: Issue angular-ui#520
@pkozlowski-opensource
Copy link
Member

@joshdmiller How do you feel about this one? IMO we should focus on #220 (which would solve this issue as well) but at the same time this is rather simple change...

@pkozlowski-opensource
Copy link
Member

BTW a13740c is a separate thing, right? We've got a PR for this already (#389) but we are still debating IE8 support

@dcg
Copy link
Author

dcg commented Jul 9, 2013

a13740c shouldn't be in this PR it's indeed the same as #389

@dcg
Copy link
Author

dcg commented Jul 9, 2013

Sorry, this is my first PR. is there a way to remove Commit a13740c from this PR?

@pkozlowski-opensource
Copy link
Member

@dcg you would have to do:

  • git reset HEAD~1
  • git push --force

But don't worry, we can pick-up only a relevant commit.

@dcg
Copy link
Author

dcg commented Jul 10, 2013

I removed a13740c just to keep it clean.

I think that #220 is kind of another problem. If you use popovers as a kind of big tooltips the inline option is nice and with less overhead. Also it keeps things consistent with tooltips.

e.g.

<a href... popover-unsafe-html="This is a Help but please <b> focus </b> on this"> ...

@pkozlowski-opensource
Copy link
Member

@dcg unsafe-html is a hack really and I would rather focus on getting support for #220. We've introduced the "unsafe" version for tooltips as you don't usually put much markup in those. But for popovers it will be really a pain... So I would really prefer to focus on #220 that is going to address this issue (and many others as well!)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants