Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

feat(pagination): make unselectable and cursor:pointer #627

Closed
tfnico opened this issue Jul 5, 2013 · 5 comments
Closed

feat(pagination): make unselectable and cursor:pointer #627

tfnico opened this issue Jul 5, 2013 · 5 comments

Comments

@tfnico
Copy link

tfnico commented Jul 5, 2013

When playing around with the pagination in http://angular-ui.github.io/bootstrap/#/pagination - it feels a bit wrong:

  • Hovering over the pages does not switch the curser to pointer-mode
  • Double-clicking will select text, which makes it look weird and ugly

I've solved this in my own app by applying these styles around the pagination element, and it feels quite nice:

.pagination {
  cursor:pointer;

  text-align: center;
  -webkit-user-select: none; /* Chrome/Safari */
  -moz-user-select: none; /* Firefox */
  -ms-user-select: none; /* IE10+ */

  /* Rules below not implemented in browsers yet */
  -o-user-select: none;
  user-select: none;
}

Plunker demo: http://plnkr.co/edit/OssCsw?p=preview

Maybe you want to make this the default look & feel. I'm not sure how to build this into angular-ui/javascript (yet), so I'll just leave it with the idea.

@pkozlowski-opensource
Copy link
Member

@tfnico We don't provide any CSS classes as part of this project so we don't really have a place to add those proposed classes.

The problem is really in the Bootstrap's CSS, you can find more info in #475 and #174

@angular-ui/bootstrap honestly I'm not sure what we could do here... Any ideas?

@tfnico
Copy link
Author

tfnico commented Jul 5, 2013

@pkozlowski-opensource Oh, sorry I didn't already see this reported. I just looked at the first five issues that appeared in the GitHub search bar when searching for pagination and assumed those were the early ones.

Perhaps it would suffice to suggest this styling in the documentation?

@ajoslin
Copy link
Contributor

ajoslin commented Jul 27, 2013

@tfnico Could you add a PR to the docs for this to suggest it? You could just link to this PR.

src/pagination/docs/
Just add something like

Suggested for looks: add css stuff.  

Discussed in [issue 627](https://github.com/angular-ui/bootstrap/issues/627)

tfnico added a commit to tfnico/bootstrap that referenced this issue Aug 3, 2013
@tfnico
Copy link
Author

tfnico commented Aug 3, 2013

Not sure if that's what you had in mind, but it's a start :)

@pkozlowski-opensource
Copy link
Member

Added info (and changes to the demo page) in 8620aed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants