Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

demo(rating): fix badge #1290

Closed
wants to merge 1 commit into from
Closed

Conversation

bekos
Copy link
Contributor

@bekos bekos commented Nov 24, 2013

Fixed the badge but also added some classes for the examples.

@pkozlowski-opensource Tell me if it's ok so I can make the changes as I go with each directive, but I suppose since we add some classes for our demo it's easy to change later.

@pkozlowski-opensource
Copy link
Member

@bakos, nice to see you around on the project!
Now, regarding this PR - actually I was recently removing all the grey backgrounds from examples to make the demo page lighter and more BS3-like :-) Also, I don't think using gradients goes in the BS3 direction, although this is a matter of personal taste, I guess.

More importantly, I would like to keep the demo page very short, sexy and snappy and move more complex usage scenarios to the reference documentation generated as on the AngularJS project.

What do you think of removing this grey / gradient thing?

@bekos
Copy link
Contributor Author

bekos commented Nov 26, 2013

@pkozlowski-opensource No problem removing the grey/gradient! Anyway my design taste is not very good :-)

My point was that we should start adding classes and common markup for each example so we can easily change it, and keep the feel of the demo consistent. If that is OK I can try to change the css classes color etc, and try to apply the the same format on every directive.

Otherwise, I can change this PR just to the badge fix.

Badges in BS3 don't have contextual styles anymore.
@bekos
Copy link
Contributor Author

bekos commented Nov 27, 2013

@pkozlowski-opensource Removed styling, since I see many PRs about this, and just left the badge fix.

bekos added a commit that referenced this pull request Nov 29, 2013
Badges in BS3 don't have contextual styles anymore.

Closes #1290
@pkozlowski-opensource
Copy link
Member

Landed in the bootstrap3 branch as d7c69d4, thnx!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants