This repository was archived by the owner on May 29, 2019. It is now read-only.
Tab active function fix #1562
Closed
Tab active function fix #1562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test case will cause the following error:
Chrome 31.0 (Linux) tabs active should allow a function as an argument FAILED
TypeError: undefined is not a function
at Object.fn (/home/sonny/src/vendor/bootstrap/src/tabs/tabs.js:207:11)
at Scope.$digest (/home/sonny/src/vendor/bootstrap/misc/test-lib/angular.js:11783:29)
at Scope.$apply (/home/sonny/src/vendor/bootstrap/misc/test-lib/angular.js:12036:24)
at generateElm (/home/sonny/src/vendor/bootstrap/src/tabs/test/tabs.spec.js:491:15)
at null.<anonymous> (/home/sonny/src/vendor/bootstrap/src/tabs/test/tabs.spec.js:500:13)
Chrome 31.0 (Linux): Executed 532 of 532 (1 FAILED) (22.178 secs / 21.353 secs)
by assigning angular.noop to setActive when getActive has an undefined assign property
|
Related to #1539 . Currently the active attribute doesn't support (non-assignable) expressions. |
ghost
assigned 
|
Looks like newer versions do not need this workaround, so I'm closing this. Thanks for all the good work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was encountering some problems using a a function for the
activeattribute on thetabsetelement. I was able to track down the issue to an undefined function, and have set it toangular.noopwhen instead. This pull request includes both a failing test case and the fix.Please let me know if this needs any additional work before getting pulled in.