This repository was archived by the owner on May 29, 2019. It is now read-only.
refactor(tooltip): remove observers #1817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the observers hurt that much? I agree that they are not likely to change though. |
|
@Foxandxss , they don't hurt that much. However, they add overhead to the page even though the tooltips aren't visible. |
|
@Foxandxss yes, the main goal for removing observers is to simplify this directive / service, both in terms of LOC and conceptual overhead. You simply don't need to think "what happens if this value changes, what do I need to update, what do I need to clean-up" for cases where change doesn't make sense from the usage point of view. |
|
Good, I am always on the learning perspective :P |
This was referenced Nov 2, 2014
There's no need for an observer here because these values are only used on initialization of the tooltip.
This change fixes the usage of the tooltip directive with AngularJS 1.3.1 when no trigger attribute is used. BREAKING CHANGE: tooltip/popover trigger is no longer a watched attribute. This affects both popovers and tooltips. The triggers are now set up once and can no longer be changed after initialization.
chrisirhc
force-pushed
the
feature/tooltip-remove-observers
branch
from
bb329d2 to
a65bea9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1600. Lazily evaluate values only when they're needed.
Breaking change:
It's possible to remove the observers for title and content and lazily evaluate them as well. That part can also be abstracted into a controller method.