Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

HTML Supporting in Popover #2187

Closed
wants to merge 8 commits into from
Closed

Conversation

MBehtemam
Copy link

Add supporting for html in popover now we can use some thing like this :

<button popover-placement="top" popover="<strong>On the Top!</strong>" class="btn btn-default" html="true">Top</button>

@kelkes
Copy link

kelkes commented May 13, 2014

dude.. fix your typo, i could use this merged

@MBehtemam
Copy link
Author

i do not know why my codes failed in firefox test. i try to find and fix the problem.

changing variable ture to true for passing test. now it support html in
popover
@MBehtemam
Copy link
Author

finally i fix the problem and find my mistake.now popover can support html.

@willsoto
Copy link

+1

@kentcdodds
Copy link

Would love to see this merged. But I don't know why you committed the karma.conf.js file change. Not everyone's on windows you know... There's no way this PR is getting pulled in with that change...

@nebruin
Copy link

nebruin commented Jun 8, 2014

+1 I really need this to use the AngularUI Bootstrap stuff.

@jonykalavera
Copy link

so the attribute would be popover-html="true" ??

@MBehtemam
Copy link
Author

in my samples and code it's html="true" but if it's conflict with something else we can change it to popover-html="true" .

@mnapoli
Copy link

mnapoli commented Jun 9, 2014

Why not like the tooltip (which is tooltip-html-unsafe): popover-html-unsafe?

@jonykalavera
Copy link

yeah i think it should be consistent with the other directive.

@pderksen
Copy link

I'd love to see this go into master soon.

@NateRedding
Copy link

I have created a new pull request #2387 which achieves this in a fashion much more similarly to tooltip-html-unsafe.

@chrisirhc
Copy link
Contributor

Closing this in favor of #2387 as it's more consistent and contains tests.
Thank you @MBehtemam.

@chrisirhc chrisirhc closed this Jun 30, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants