feat(tooltip): support placement="mouse"

[lanterndev]

• uses $position service's new mouse() API
• works for popover too

[joshdmiller]

Hey @Skivvies - I don't have a problem including something like this, even if Twitter did explicitly choose to exclude it. The code is clean enough for me. Two things, though -

1. Is this cross-platform? At least WebKit, Firefox, and IE9+?
2. Can you add some unit tests?

Other than that, looks good to me.

[bekos]

This change unconditionally binds a document mousemove event through position service. Although the operations inside it's handler are not that heavy, it's an unnecessary performance penalty.
Probably you should optimize this, by binding it on mouseenter and unbinding on mouseleave.

[lanterndev]

@joshdmiller wrote:

Hey @Skivvies - I don't have a problem including something like this, even if Twitter did explicitly choose to exclude it. The code is clean enough for me. Two things, though -

1. Is this cross-platform? At least WebKit, Firefox, and IE9+?
2. Can you add some unit tests?

Other than that, looks good to me.

Awesome! I tested in Chrome, Safari, Firefox, and IE9, and they're all working.

Re unit tests, I actually looked in https://github.com/angular-ui/bootstrap/blob/master/src/tooltip/test/tooltip.spec.js for unit tests for the other placement options ("left", "right", etc.) so I could add one for "mouse", but none of them are currently being tested. I wasn't sure if there was some good reason you're not testing the other options (maybe it's messy to check that the tooltip's position matches expectations), so I didn't add it. Would it make sense to accept this without the mouse-placement-specific unit test, and add tests for all the placement options in a separate PR?

[joshdmiller]

Landed as ace7bc6.

[lanterndev]

Thanks for merging!

On Sun, Jun 23, 2013 at 1:24 PM, Josh David Miller <[email protected]

wrote:

Landed as ace7bc6 ace7bc6
.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/527#issuecomment-19877515
.