This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Add support for tabindex on focusser input #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the ability to specify tabindex on the ui-select element and have it passed to the focusser input. The tabindex is removed from the ui-select div after it is applied to the focusser input.
|
LGTM but keep in mind that we now support multiselect, so will be better if we can give support for this feature for both (single and multiple). On multiselect mode, we dont have a focusser since the search input is always visible, so we could just implement same functionality to that input in case its multiple |
If the ui-select is in multiple mode, add the tabindex to the search input instead of the focusser.
|
Added. I wasnt 100% sure where I should do the query for the searchInput. |
dimirc
added a commit
that referenced
this pull request
Sep 10, 2014
Add support for tabindex on focusser input
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the ability to specify tabindex on the ui-select
element and have it passed to the focusser input. The tabindex is
removed from the ui-select div after it is applied to the focusser
input.