Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Show x icon to clear/reset the current value (like select2) #287

Merged
merged 1 commit into from
Nov 24, 2014

Conversation

dimirc
Copy link
Contributor

@dimirc dimirc commented Oct 10, 2014

Plunker demo

PD: only working on select2 theme

@amcdnl
Copy link
Contributor

amcdnl commented Oct 17, 2014

Note: Even if no value is selected the X still shows up. http://www.screencast.com/t/VrIv6jWTgP0

I debugged and found that it was caused by in isEmpty the ctrl.selected was equal to 0 rather than undefined. Adding a check for 0 resolved the issue but i dont think thats the right fix.

@oslo10e
Copy link

oslo10e commented Nov 5, 2014

Here an other demo with standard theme (not select2)
http://jsfiddle.net/opeaucelle/peypok0c/embedded/result/

@davidt99
Copy link

davidt99 commented Nov 6, 2014

@oslo10e, the demo doesn't seems to work, can you fix that?

@oslo10e
Copy link

oslo10e commented Nov 6, 2014

@davidt99 I have updated jsfiddle to make it work back

@seiyria
Copy link

seiyria commented Nov 14, 2014

Any idea when this can get merged, and when it could be supported on more themes?

@jlfama
Copy link

jlfama commented Nov 21, 2014

Could definitely use this feature. Any idea on when or if this will be getting merged?

@amcdnl
Copy link
Contributor

amcdnl commented Nov 21, 2014

@dimirc any reason why not to merge this?

@dimirc
Copy link
Contributor Author

dimirc commented Nov 21, 2014

@amcdnl because its only working with select2 theme, maybe we could first merge only this "partial" support or wait until later to implement on the other themes too

@amcdnl
Copy link
Contributor

amcdnl commented Nov 24, 2014

@dimirc Sounds good. I went ahead and merged since there is such popular demand. Lets close this issue and create a new one for more theme support?

amcdnl added a commit that referenced this pull request Nov 24, 2014
Show x icon to clear/reset the current value (like select2)
@amcdnl amcdnl merged commit f672837 into master Nov 24, 2014
@dimirc dimirc deleted the feat-allowclear branch November 24, 2014 18:14
@jbpionnier
Copy link

Are there any plans to add support to bootstrap theme ? 😃

@amcdnl
Copy link
Contributor

amcdnl commented Dec 7, 2014

PR welcome ;)

@DanielClausen
Copy link
Contributor

I just added a PR to add this functionality to the bootstrap theme. See PR #486.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants