This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Reset activeIndex on popup close in case we highlighted another choice without selecting it #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 13, 2014 14:40
…t time we open the popup
…when we close popup)
ProLoser
added a commit
that referenced
this pull request
Jun 24, 2014
Reset activeIndex on popup close in case we highlighted another choice without selecting it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we open the popup and select a choice without validating it, this choice will be kept the next time we open the popup. This is not what we want.
This pull request reset the activeIndex by the selected index when we close popup.