Skip to content

ng add @angular/pwa doesn't correctly edit the index.html #11942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adrianojosue opened this issue Aug 19, 2018 · 1 comment · Fixed by #11953
Closed

ng add @angular/pwa doesn't correctly edit the index.html #11942

adrianojosue opened this issue Aug 19, 2018 · 1 comment · Fixed by #11953

Comments

@adrianojosue
Copy link

adrianojosue commented Aug 19, 2018 •
edited
Loading

ng add @angular/pwa doesn't correctly edit the index.html

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [x] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/


Angular CLI: 6.1.4
Node: 8.11.3
OS: win32 x64
Angular: 6.1.3
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router, service-worker

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.7.4
@angular-devkit/build-angular     0.7.4
@angular-devkit/build-optimizer   0.7.4
@angular-devkit/build-webpack     0.7.4
@angular-devkit/core              0.7.4
@angular-devkit/schematics        0.7.4
@angular/cli                      6.1.4
@angular/pwa                      0.7.4
@ngtools/webpack                  6.1.4
@schematics/angular               0.7.4
@schematics/update                0.7.4
rxjs                              6.2.2
typescript                        2.7.2
webpack                           4.9.2

Repro steps

ng new my-app --style=scss --routing
cd my-app
ng add @angular/pwa

The log given by the failure

BEFORE ng add @angular/pwa

<!doctype html>
<html lang="en">
<head>
  <meta charset="utf-8">
  <title>my-app</title>
  <base href="https://github.com/">

  <meta name="viewport" content="width=device-width, initial-scale=1">
  <link rel="icon" type="image/x-icon" href="favicon.ico">
</head>
<body>
  <app-root></app-root>
</body>
</html>

AFTER ng add @angular/pwa

<!doctype html>
<html lang="en">
<head>
  <meta charset="utf-8">
  <title>my-app</title>
  <base href="https://github.com/">

  <meta name="viewport" content="width=device-width, initial-scale=1">
  <link rel="icon" type="image/x-icon" href="favicon.ico">
  <link rel="manifest" href="manifest.json">
  <meta name="theme-color" content="#1976d2">
</head>
<body>
  <app-root></app-root>
  <noscript>Please enable JavaScript to continue using this application.</noscript>
</head>                     <------|
<body>                      <------|-----INCORRECTLY TAGS ADDED
  <app-root></app-root>     <------|
</body>
</html>
clydin added a commit to clydin/angular-cli that referenced this issue Aug 20, 2018
@clydin
fix(@angular/pwa): properly write closing body tag when modifying index
2f21849 
Fixes angular#11543
Fixes angular#11942
@clydin clydin mentioned this issue Aug 20, 2018
Merged
hansl pushed a commit that referenced this issue Aug 20, 2018
@clydin @hansl
fix(@angular/pwa): properly write closing body tag when modifying index
ad84bb1 
Fixes #11543
Fixes #11942
hansl pushed a commit that referenced this issue Aug 20, 2018
@clydin @hansl
fix(@angular/pwa): properly write closing body tag when modifying index
98d4d30 
Fixes #11543
Fixes #11942
This was referenced Sep 22, 2018
Closed
Closed
Closed
Closed
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@angular/pwa): properly write closing body tag when modifying index clydin/angular-cli
1 participant
@adrianojosue