extract licenses does not include all licenses

[janwo]

🐞 Bug report

Command (mark with an x)

• new
• build
• serve
• test
• e2e
• generate
• add
• update
• lint
• extract-i18n
• run
• config
• help
• version
• doc

Description

Some licenses of project dependencies are missing, e.g. 3rdpartylicenses.txt does not come with licenses of rxjs.

zone.js
MIT
The MIT License

Copyright (c) 2010-2020 Google LLC. https://angular.io/license

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

🔬 Minimal Reproduction

1. Create a new project using ng new ("@angular/cli": "^12.1.1")
2. Run ng build
3. Check dist/3rdpartylicenses.txt

🔥 Exception or Error

No error is thrown. Some licenses are missing (rxjs).

🌍 Your Environment

    _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 12.1.1
Node: 15.13.0 (Unsupported)
Package Manager: npm 7.19.0
OS: darwin arm64

Angular: 12.1.1
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1201.1
@angular-devkit/build-angular   12.1.1
@angular-devkit/core            12.1.1
@angular-devkit/schematics      12.1.1
@schematics/angular             12.1.1
rxjs                            6.6.7
typescript                      4.3.5

Hope you can help :-)

[alan-agius4]

Hi @janwo, Unless I am missing something the RxJs JS bundles don't contain any license headers.

Ex: https://unpkg.com/browse/rxjs@6.6.7/_esm2015/index.js

[janwo]

License files are not considered? See https://unpkg.com/browse/rxjs@6.6.7/LICENSE.txt

[alan-agius4]

Missed that file, yeah it should consider that. Will try to take a look at this sometime this week. Although likely this is an upstream issue in https://github.com/xz64/license-webpack-plugin.

[alan-agius4]

Found the root cause xz64/license-webpack-plugin#103