-
Notifications
You must be signed in to change notification settings - Fork 12k
v1.7.x with typescript 2.6.x css escape regression #9567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
After some investigation, this appears to be a TypeScript issue. This PR changed the string escaping code: microsoft/TypeScript#18026 |
Thank you for the investigation! |
1.6.x and earlier used a different stylesheet optimization pipeline which coincidentally collapsed escaped values to a short form if possible (i.e., |
i get the same problem with 1.7.0 (which is released today) |
I can't test now, but this might have been fixed by angular/angular#22776. |
Thanks for reporting this issue. This issue is now obsolete due to changes in the recent releases. Please update to the most recent Angular CLI version. If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Versions
Repro steps
@angular/cli
to 1.7.0-rc.0 andtypescript
to 2.5.3 (kondi/clicssbug@8448fe9 and kondi/clicssbug@63ed10e)ng serve --prod
=> "A: A Welcome to app!" (works well)ng serve --prod
=> "A: x00041 Welcome to app!" (buggy build)Observed behavior
The prod build changes the escaping in the string literal of CSS rule to invalid
\x00041
:Desired behavior
It should not change the represented value of the string literal.
Mention any other details that might be useful (optional)
styles.css
=> OKThe syntax I used in the CSS literal is quite common if you use font icons.
The text was updated successfully, but these errors were encountered: