feat(@angular/cli): add flags to the process title #11920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
requested changes
Aug 16, 2018
packages/angular/cli/bin/ng
Outdated
|
|
||
| var version = process.version.substr(1).split('.'); | ||
| const version = process.version.substr(1).split('.'); |
There was a problem hiding this comment.
This can potentially be run from an old version of node which doesn’t support const. It would crash instead of displaying the error message
There was a problem hiding this comment.
Ah. I was wondering why that was there. Fixed.
hansl
force-pushed
the
fix-process-title
branch
from
4ccaa04 to
958e54e
Compare
clydin
previously approved these changes
Aug 16, 2018
hansl
force-pushed
the
fix-process-title
branch
from
958e54e to
2625ca8
Compare
|
@hansl ah great! Looking forward to seeing it live in CLI! Thanks and have a great day! |
hansl
force-pushed
the
fix-process-title
branch
2 times, most recently
from
c7a2a2f to
04ca274
Compare
clydin
previously approved these changes
Aug 17, 2018
Closes angular#8772 Fixes angular#6888 Special thanks to @tomastrajan for original PR.
hansl
force-pushed
the
fix-process-title
branch
from
04ca274 to
93bdf75
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8772
Fixes #6888
Special thanks to @tomastrajan for original PR.