Skip to content

fix(@schematics/angular): generate application failing when projectRoot is provided #11925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(@schematics/angular): generate application failing when projectRoot is provided #11925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62d0728
fix(@schematics/angular): generate application with projectRoot is pr…
vovikdrg Aug 17, 2018
d48360d
fix(@schematics/angular): to build proper path for e2e in new project…
vovikdrg Aug 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions docs/documentation/generate/application.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,3 +96,12 @@ Create an Angular application.
Do not add dependencies to package.json.
</p>
</details>
<details>
<summary>project-root</summary>
<p>
<code>--project-root</code>
</p>
<p>
Specify root folder for new application and e2e tests
</p>
</details>
2 changes: 1 addition & 1 deletion docs/documentation/stories/multiple-projects.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ To create another app you can use the following command:
ng generate application my-other-app
```

The new application will be generated inside `projects/my-other-app`.
The new application will be generated inside `projects/my-other-app`. If you wish to override root folder specify `--project-root applicationPath`

Now we can `serve`, `build` etc. both the apps by passing the project name with the commands:

Expand Down
4 changes: 1 addition & 3 deletions packages/schematics/angular/application/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,10 +270,8 @@ export default function (options: ApplicationOptions): Rule {
name: `${options.name}-e2e`,
relatedAppName: options.name,
rootSelector: appRootSelector,
projectRoot: newProjectRoot ? `${newProjectRoot}/e2e` : 'e2e',
};
if (options.projectRoot !== undefined) {
e2eOptions.projectRoot = 'e2e';
}

return chain([
addAppToWorkspaceFile(options, workspace),
Expand Down