fix(@angular/cli): command runner is not working on windows

[alan-agius4]

fs is unable to read the normalized paths from @angular-devkit/core on windows as the disk drive is replaced from c:/ to /c/

Closes #11928

Another alternative is to use getSystemPath in all the places where the is readFileSync within the runner. But I found the current implementation to be cleaner.

This was not caught in CI, as in AppVeyor we are not running test-cli-e2e

[alan-agius4]

Note: dirname will internally normalize the path before returning.

[alexeagle]

FYI @hansl looks like it was introduced in your 2ce1155#diff-53bc4547164f6bfb4fee01f58a298892

[alan-agius4]

On another note, is it really required to remove the : when normalizing paths?

[hansl]

@alan-agius4 there's a misunderstanding here;

1. I did not catch the change in time in my PR, sorry about that. The original PR was the one introducing the error, but I should have caught it.
2. normalize and Path are devkit concepts. They should never be mixed with Node fs methods. Core does not understand Node fs, so it's okay. All those Path types are useable in devkit's hosts and general methods. They're meant to be platform independent, so no : or http: or anything weird like that. They just represent paths; absolute or relative, directory names separated by /. That's all. They should never be used outside of core methods.
3. I'd like to move the Path type at some point to not be a subtype of string, but be a unique symbol. That way people won't make that mistake again. But in the meantime we have to deal with this.

[alan-agius4]

@hansl thanks for the clarifications. 👍

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}