Skip to content

fix: limit rxjs to 6.2.x due to a defect in 6.3.0 #12048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2018
Merged

fix: limit rxjs to 6.2.x due to a defect in 6.3.0 #12048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
"license-checker": "^20.1.0",
"minimatch": "^3.0.4",
"minimist": "^1.2.0",
"rxjs": "^6.0.0",
"rxjs": "~6.2.0",
"semver": "^5.3.0",
"source-map": "^0.5.6",
"source-map-support": "^0.5.0",
Expand All @@ -107,6 +107,6 @@
"resolutions": {
"@types/webpack": "4.4.0",
"@types/webpack-dev-server": "2.9.4",
"rxjs": "6.0.0"
"rxjs": "~6.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's the same as the main one, then you can remove this line IIRC.

}
}
2 changes: 1 addition & 1 deletion packages/angular/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"inquirer": "^6.1.0",
"json-schema-traverse": "^0.4.1",
"opn": "^5.3.0",
"rxjs": "^6.0.0",
"rxjs": "~6.2.0",
"semver": "^5.1.0",
"symbol-observable": "^1.2.0",
"yargs-parser": "^10.0.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/architect/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
"typings": "src/index.d.ts",
"dependencies": {
"@angular-devkit/core": "0.0.0",
"rxjs": "^6.0.0"
"rxjs": "~6.2.0"
}
}
2 changes: 1 addition & 1 deletion packages/angular_devkit/architect/test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"builders": "builders.json",
"dependencies": {
"rxjs": "^6.0.0"
"rxjs": "~6.2.0"
}
}
2 changes: 1 addition & 1 deletion packages/angular_devkit/architect_cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"@angular-devkit/architect": "0.0.0",
"minimist": "^1.2.0",
"symbol-observable": "^1.2.0",
"rxjs": "^6.0.0"
"rxjs": "~6.2.0"
}
}
2 changes: 1 addition & 1 deletion packages/angular_devkit/build_angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"postcss-loader": "^2.1.5",
"postcss-url": "^7.3.2",
"raw-loader": "^0.5.1",
"rxjs": "^6.0.0",
"rxjs": "~6.2.0",
"sass-loader": "^7.1.0",
"semver": "^5.5.0",
"source-map-support": "^0.5.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/build_ng_packagr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"dependencies": {
"@angular-devkit/architect": "0.0.0",
"@angular-devkit/core": "0.0.0",
"rxjs": "^6.0.0",
"rxjs": "~6.2.0",
"semver": "^5.3.0"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/build_webpack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"dependencies": {
"@angular-devkit/architect": "0.0.0",
"@angular-devkit/core": "0.0.0",
"rxjs": "^6.0.0"
"rxjs": "~6.2.0"
},
"peerDependencies": {
"webpack": "^4.6.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
"chokidar": "^2.0.3",
"fast-json-stable-stringify": "^2.0.0",
"source-map": "^0.5.6",
"rxjs": "^6.0.0"
"rxjs": "~6.2.0"
}
}
2 changes: 1 addition & 1 deletion packages/angular_devkit/schematics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@
],
"dependencies": {
"@angular-devkit/core": "0.0.0",
"rxjs": "^6.0.0"
"rxjs": "~6.2.0"
}
}
2 changes: 1 addition & 1 deletion packages/angular_devkit/schematics_cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"@schematics/schematics": "0.0.0",
"minimist": "^1.2.0",
"symbol-observable": "^1.2.0",
"rxjs": "^6.0.0"
"rxjs": "~6.2.0"
}
}
2 changes: 1 addition & 1 deletion packages/ngtools/webpack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
"dependencies": {
"@angular-devkit/core": "0.0.0",
"rxjs": "^6.0.0",
"rxjs": "~6.2.0",
"tree-kill": "^1.0.0",
"webpack-sources": "^1.1.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/schematics/angular/utility/latest-versions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
export const latestVersions = {
// These versions should be kept up to date with latest Angular peer dependencies.
Angular: '^6.1.0',
RxJs: '^6.0.0',
RxJs: '~6.2.0',
ZoneJs: '~0.8.26',
TypeScript: '~2.9.2',
// The versions below must be manually updated when making a new devkit release.
Expand Down
2 changes: 1 addition & 1 deletion packages/schematics/update/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
"npm-registry-client": "^8.5.1",
"semver": "^5.3.0",
"semver-intersect": "^1.1.2",
"rxjs": "^6.0.0"
"rxjs": "~6.2.0"
}
}
2 changes: 1 addition & 1 deletion tests/angular_devkit/build_angular/hello-world-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@angular/platform-browser-dynamic": "^6.0.0-rc.0",
"@angular/router": "^6.0.0-rc.0",
"core-js": "^2.4.1",
"rxjs": "^6.0.0",
"rxjs": "~6.2.0",
"zone.js": "^0.8.19"
},
"devDependencies": {
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6371,9 +6371,9 @@ run-queue@^1.0.0, run-queue@^1.0.3:
dependencies:
aproba "^1.1.1"

[email protected], rxjs@^6.0.0, rxjs@^6.1.0:
version "6.0.0"
resolved "https://registry.yarnpkg.com/rxjs/-/rxjs-6.0.0.tgz#d647e029b5854617f994c82fe57a4c6747b352da"
rxjs@^6.0.0, rxjs@^6.1.0, rxjs@~6.2.0:
version "6.2.2"
resolved "https://registry.yarnpkg.com/rxjs/-/rxjs-6.2.2.tgz#eb75fa3c186ff5289907d06483a77884586e1cf9"
dependencies:
tslib "^1.9.0"

Expand Down