Skip to content

Conversation

alan-agius4
Copy link
Collaborator

Closes #12192

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed cla: yes labels Sep 7, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@@ -322,7 +322,7 @@
"library"
]
},
"architect": {
"targets": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either one (but not both at the same time) should be allowed for 7.x. Unfortunately, this makes the schema far more complicated.

"required": ["architect"]
}
},
{
Copy link
Collaborator Author

@alan-agius4 alan-agius4 Sep 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because targets and architect are not really required. If they were it could have been something like

"oneOf": [
        {
            "required": ["targets"]
         },
        {
            "required": ["architect"]
        }
]

@clydin clydin removed the cla: yes label Sep 19, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@hansl hansl merged commit e6f9ae9 into angular:master Sep 19, 2018
@alan-agius4 alan-agius4 deleted the fix_schema_cli branch September 20, 2018 07:11
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema doesn't support 'targets'
4 participants