Skip to content

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Sep 27, 2018

Add progress option to xi18n. It is passed to the webpack builder.

Fixes #11667.

@hansl
Copy link
Contributor Author

hansl commented Sep 27, 2018

Unfortunately webpack uses process write directly and it's proven impossible to test properly. I tested this manually. There's also no test for the progress option in other packages.

@hansl hansl added the target: major This PR is targeted for the next major release label Sep 27, 2018
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filipesilva
filipesilva previously approved these changes Sep 27, 2018
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside of what @alan-agius4 requested.

@hansl
Copy link
Contributor Author

hansl commented Sep 27, 2018

Done.

@hansl hansl merged commit a13d74c into angular:master Sep 27, 2018
@hansl hansl deleted the fix-11667 branch November 29, 2018 01:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[XI18N] Unknown option: '--progress'
4 participants