-
Notifications
You must be signed in to change notification settings - Fork 12k
feat(@angular-devkit/build-ng-packagr): implement stable architect API #13877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c6559d5
to
0e3a225
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit from me.
@@ -1,4 +1,5 @@ | |||
{ | |||
"$schema": "http://json-schema.org/draft-07/schema", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering the draft won't be changing much, we should start using a non-draft version of the schema spec; http://json-schema.org/schema
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://json-schema.org/schema
points to latest version of the schema and will change over time. It currently points to the draft-07
version which allows everything to work for now. However, there is no guarantee that the latest version will be supported by the CLI nor that the file will conform to the latest version. By specifying a specific version the $schema
identifier can be used as both a version identifier for the format of the file and as the location of the schema. This allows processors to use the specified version/format of the specification when parsing and processing the file. (ref: http://json-schema.org/draft-07/json-schema-core.html#rfc.section.7)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(we use that value too when running quicktype)
This is non blocking, but we use the "latest" URI in all but 2 of our schemas, so I'd say it's better to use the same everywhere than just keep splitting the code base.
0e1c132
to
490467c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
490467c
to
a9fc9fa
Compare
a9fc9fa
to
7f0e037
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This is a continuation of the Angular builder refactoring following the introduction of the new stable architect builder API.