Skip to content

test: comment out broken assertion #13911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2019
Merged

test: comment out broken assertion #13911

merged 1 commit into from
Mar 13, 2019

Conversation

alexeagle
Copy link
Contributor

there's a test isolation failure - it was passing locally but not on CI when the two specs are run in a different order

@alexeagle alexeagle requested a review from hansl March 13, 2019 21:27
@alexeagle alexeagle added the target: major This PR is targeted for the next major release label Mar 13, 2019
@vikerman vikerman merged commit fe229fa into angular:master Mar 13, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hansl hansl Awaiting requested review from hansl

Assignees
No one assigned
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexeagle @vikerman @googlebot