Skip to content

ci: test on node 12 #14349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2019
Merged

ci: test on node 12 #14349

merged 1 commit into from
May 9, 2019

Conversation

filipesilva
Copy link
Contributor

No description provided.

@filipesilva
Copy link
Contributor Author

The tests/basic/update-7.0 e2e test fails with the error below:

ENOENT: no such file or directory, stat '/tmp/angular-cli-e2e-201947-111-1sw3b9b.v5l8/assets/7.0-project-1557230497707/node_modules/.bin/in-install'

This seems to be related to node-sass rollback when using --force on update. #14331 removes the need to force on update so that should clear this too.

@filipesilva filipesilva added the target: patch This PR is targeted for the next patch release label May 8, 2019
@filipesilva filipesilva requested a review from clydin May 8, 2019 15:29
@kyliau kyliau merged commit 3a1df53 into angular:master May 9, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants